Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up mess in ArrayHelper::multisort() #9 #27

Merged
merged 3 commits into from
Apr 20, 2020

Conversation

mapeveri
Copy link
Contributor

Q A
Is bugfix? ✔️
New feature?
Breaks BC?
Tests pass? ✔️

This PR is related to the Issue #9

@samdark samdark requested a review from a team April 19, 2020 20:13
@samdark samdark added the status:code review The pull request needs review. label Apr 19, 2020
src/ArrayHelper.php Outdated Show resolved Hide resolved
src/ArrayHelper.php Outdated Show resolved Hide resolved
Copy link
Member

@samdark samdark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 overall.

tests/ArrayHelperTest.php Outdated Show resolved Hide resolved
@samdark samdark merged commit aabbb81 into yiisoft:master Apr 20, 2020
@samdark
Copy link
Member

samdark commented Apr 20, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants