Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring #38

Merged
merged 15 commits into from Feb 10, 2021
Merged

Refactoring #38

merged 15 commits into from Feb 10, 2021

Conversation

rustamwin
Copy link
Member

Q A
Is bugfix? ✔️
New feature? ✔️
Breaks BC? ✔️
Fixed issues #35

@rustamwin rustamwin added the status:under development Someone is working on a pull request. label Feb 7, 2021
Copy link
Member

@samdark samdark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks alright overall. Need readme and phpdoc updated before merge.

src/TokenRepositoryInterface.php Outdated Show resolved Hide resolved
@rustamwin rustamwin added status:code review The pull request needs review. and removed status:under development Someone is working on a pull request. labels Feb 9, 2021
@samdark samdark merged commit 7f63cb3 into master Feb 10, 2021
@samdark samdark deleted the refactoring branch February 10, 2021 10:58
@samdark
Copy link
Member

samdark commented Feb 10, 2021

Awesome. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants