Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean all the tests. #59

Merged
merged 7 commits into from
May 1, 2023
Merged

Clean all the tests. #59

merged 7 commits into from
May 1, 2023

Conversation

terabytesoftw
Copy link
Member

Q A
Is bugfix? ✔️
New feature?
Breaks BC?

@what-the-diff
Copy link

what-the-diff bot commented Apr 27, 2023

PR Summary

  • Updated column 'id' type
    Changed the type of column 'id' to a more appropriate TYPE_STRING
  • Updated column 'data' type
    Changed the type of column 'data' to a more suitable TYPE_BINARY
  • Updated column 'expire' type
    Changed the type of column 'expire' for better compatibility to TYPE_INTEGER

@codecov
Copy link

codecov bot commented Apr 27, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (cf3baa5) 100.00% compared to head (4894246) 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##              master       #59   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity        53        53           
===========================================
  Files              2         2           
  Lines            144       144           
===========================================
  Hits             144       144           
Impacted Files Coverage Δ
src/DbCache.php 100.00% <ø> (ø)
src/DbHelper.php 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@terabytesoftw terabytesoftw requested a review from a team April 28, 2023 12:03
@terabytesoftw terabytesoftw added the status:code review The pull request needs review. label Apr 28, 2023
@terabytesoftw terabytesoftw merged commit 4ffc6a9 into master May 1, 2023
150 checks passed
@terabytesoftw terabytesoftw deleted the clean-test branch May 1, 2023 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants