Update docs and config files - 1. #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
terabytesoftw
commented
Apr 27, 2023
terabytesoftw
commented
| Q | A |
|---|---|
| Is bugfix? | ❌ |
| New feature? | ✔️ |
| Breaks BC? | ❌ |
PR Summary
|
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #60 +/- ##
===========================================
Coverage 100.00% 100.00%
Complexity 53 53
===========================================
Files 2 2
Lines 144 144
===========================================
Hits 144 144 ☔ View full report in Codecov by Sentry. |
darkdef
reviewed
Apr 29, 2023
darkdef
approved these changes
Apr 29, 2023
darkdef
approved these changes
Apr 29, 2023
samdark
reviewed
May 1, 2023
| /** | ||
| * Database schema required by yiisoft/cache db for SQLite. | ||
| */ | ||
| CREATE TABLE "cache" ( |
There was a problem hiding this comment.
Do we need these considering that we have DbHelper?
There was a problem hiding this comment.
They are in the documents as additional, they are not in the package as such.
vjik
reviewed
May 1, 2023
Co-authored-by: Sergei Predvoditelev <sergei@predvoditelev.ru>
vjik
requested changes
May 1, 2023
docs/en/migration/schema-mssql.sql
Outdated
There was a problem hiding this comment.
@darkdef suggest removed because it is a bad practice, because you can mistakenly drop the table with data.
There was a problem hiding this comment.
We can add it in another PR.
Co-authored-by: Sergei Predvoditelev <sergei@predvoditelev.ru>
samdark
approved these changes
May 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.