Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Psalm level 1 #75

Merged
merged 3 commits into from
Feb 9, 2024
Merged

Psalm level 1 #75

merged 3 commits into from
Feb 9, 2024

Conversation

vjik
Copy link
Member

@vjik vjik commented Feb 9, 2024

Q A
Is bugfix?
New feature?
Breaks BC?
Fixed issues

Copy link

codecov bot commented Feb 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8b3fcef) 90.96% compared to head (8542bfe) 90.96%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master      #75   +/-   ##
=========================================
  Coverage     90.96%   90.96%           
  Complexity       71       71           
=========================================
  Files             1        1           
  Lines           155      155           
=========================================
  Hits            141      141           
  Misses           14       14           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

what-the-diff bot commented Feb 9, 2024

PR Summary

  • Improvement to GitHub Workflow Configuration
    We've updated the workflow configuration to introduce a new job named psalm80. This additional job incorporates details specific to the PHP version 8.0, ensuring that our project stays compatible with newer PHP versions.

  • Package Update in Composer File
    The 'vimeo/psalm' package version in our project has been updated to ^5.21 in our 'composer.json' file. This will help us leverage improvements and bug fixes that came with the newer version of the package.

  • Modifications to Psalm Configuration
    The 'psalm.xml' file has seen a few updates. We've made our error reporting more strict by setting the errorLevel to 1. Furthermore, we've added a rule to ignore the vendor directory to avoid unnecessary analysis and potential warnings. Lastly, we've put custom handlers for MixedAssignment and RiskyTruthyFalsyComparison to approach these issues in our own way.

  • Introduction of Psalm configuration for PHP 8.0
    We've added a new file named 'psalm80.xml' that contains Psalm configuration specific to PHP version 8.0. With this, our project can be more efficient in managing code analysis for PHP 8.0.

  • New Method Added in FileCache
    In our src/FileCache.php file, we've added a new method called iterableToArray which can convert any iterable data type into an array. This provides more versatility in handling various data types in our code. We've also added PHPDoc annotations for this method to help developers understand its purpose and usage better.

@vjik vjik merged commit 5839332 into master Feb 9, 2024
18 of 19 checks passed
@vjik vjik deleted the psalm1 branch February 9, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant