Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plugin option "package-types" #152

Merged
merged 2 commits into from
Nov 17, 2023
Merged

Add plugin option "package-types" #152

merged 2 commits into from
Nov 17, 2023

Conversation

vjik
Copy link
Member

@vjik vjik commented Nov 17, 2023

Q A
Is bugfix?
New feature? ✔️
Breaks BC?
Fixed issues #151

Copy link

codecov bot commented Nov 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a236b11) 99.57% compared to head (b7e06d6) 99.58%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #152   +/-   ##
=========================================
  Coverage     99.57%   99.58%           
- Complexity      276      277    +1     
=========================================
  Files            22       22           
  Lines           712      718    +6     
=========================================
+ Hits            709      715    +6     
  Misses            3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

what-the-diff bot commented Nov 17, 2023

PR Summary

  • Introduced New Plugin Option "Package-Types"
    This addition to the changelog file provides options for defining different types of packages during processing. By default, the types are 'library' and 'composer-plugin'. It also offers a sample configuration for adding custom package types.

  • Updated README Document
    The documentation now includes information about the new 'Package-Types' option.

  • Updated 'PackagesListBuilder' and 'ProcessHelper' Files
    Improvements to the PackagesListBuilder file include the addition of a package types property to the constructor. Additionally, it now checks if a package type is included in the provided package types array. Changes in the ProcessHelper file allow it to pass the packageTypes method from the Options class to a new PackagesListBuilder instance.

  • Changes to the 'Options' file
    A new private property named 'packageTypes' is introduced with a default value of 'library' and 'composer-plugin'. It also verifies if the package types option is available and assigns its value to packageTypes.

  • Addition of Tests for New Features
    New test methods are introduced to evaluate the behavior of processing custom package types and processing libraries only. These tests are found in the PackageFilesProcessTest file.

  • Update on 'PackagesListBuilderTest' File
    The existing test method has been updated to include the default package types from the Options class constructor.

  • Modifications to 'TestCase.php'
    It now includes an optional argument 'packageTypes' in the createComposerMock() method, which defaults to null. Further, it has defined new custom package and type within the composer.json and params.php files in the custom-type directory.

  • Addition of New Files for Testing Custom Package Types
    Two new files, composer.json, and params.php, have been included for testing the custom package types. These files are located in the custom-type directory.

Copy link

@tomaszkane tomaszkane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me it works.

README.md Show resolved Hide resolved
@vjik vjik merged commit 8b837ff into master Nov 17, 2023
19 of 21 checks passed
@vjik vjik deleted the new-option branch November 17, 2023 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants