Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to use option "config-plugin-file" in packages + Refactoring #173

Merged
merged 10 commits into from
Mar 28, 2024

Conversation

vjik
Copy link
Member

@vjik vjik commented Mar 27, 2024

Q A
Is bugfix?
New feature? ✔️
Breaks BC?

Copy link

what-the-diff bot commented Mar 27, 2024

PR Summary

  • Introduction of Configurable Packages
    A new feature has been added which allows the use of a "config-plugin-file" option in packages. This means you can now customize different packages according to your unique needs.

  • Code Refactoring of Config Settings Reader
    The process of reading config settings has been improved. This was achieved by extracting the config settings reader to a separate class, leading to a more organized and maintainable codebase.

  • Renaming of Root Configuration
    The ‘RootConfiguration’ class is now referred to as ‘ConfigSettings’. This provides a more accurate representation of the class’s functionality in the system.

  • Enhancements to Test Cases
    A new test case has been introduced that checks the package configuration with a config file. This ensures that the packaging system works smoothly and robustly, as expected. The test case has been updated to verify correct values from the config file, making our testing process more robust and reducing the possibility of any issues going unnoticed.

  • Addition of Configuration Files for Testing
    Along with the new test case, two new configuration files (params.php and web.php) have been added for the testing package. This gives us a wider range of scenarios to test and thus ensure the system's reliability.

  • Cleaning Up Unused Functions
    To make the code leaner and more efficient, unused functions in the ProcessHelper class have been removed.

Copy link

codecov bot commented Mar 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (7a80d5e) to head (6218ed5).

Additional details and impacted files
@@             Coverage Diff             @@
##              master      #173   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
+ Complexity       283       281    -2     
===========================================
  Files             23        23           
  Lines            738       728   -10     
===========================================
- Hits             738       728   -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vjik vjik requested a review from a team March 27, 2024 19:32
@vjik vjik added the status:code review The pull request needs review. label Mar 27, 2024
README.md Outdated Show resolved Hide resolved
vjik and others added 2 commits March 27, 2024 22:41
Co-authored-by: Alexander Makarov <sam@rmcreative.ru>
@vjik vjik merged commit ae3723f into master Mar 28, 2024
20 of 21 checks passed
@vjik vjik deleted the refactor branch March 28, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants