-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve config diff logic #47
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks alright 👍 Need to test it more as end user.
Before merge need:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like that dist files is optional
Great job 👍 |
Implemented in this pull request
If the configuration has been changed, a question is asked with three options:
After this selection, another question will be asked:
This question is only asked once (at the first choice).
When remove a package, will also be asked whether to remove the configuration files.
When you run the
composer create-project
command, no questions will be asked about file changes, but a list of files that were changed to run the application template will be displayed.