Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve config diff logic #47

Merged
merged 14 commits into from
Apr 26, 2021
Merged

Improve config diff logic #47

merged 14 commits into from
Apr 26, 2021

Conversation

devanych
Copy link
Member

@devanych devanych commented Apr 22, 2021

Q A
Is bugfix?
New feature? ✔️
Breaks BC?
Fixed issues #44

Implemented in this pull request

If the configuration has been changed, a question is asked with three options:

  1. Ignore, do nothing (default if just press ENTER).
  2. Replace the local version with the new version.
  3. Copy the new version of the file with the postfix ". dist".

After this selection, another question will be asked:

Apply this action to all the following files? (yes/no)

This question is only asked once (at the first choice).

When remove a package, will also be asked whether to remove the configuration files.

If you run composer update --no-interaction, nothing will be changed. But after the operation, a list of files that differ will be displayed.

When you run the composer create-project command, no questions will be asked about file changes, but a list of files that were changed to run the application template will be displayed.

@devanych devanych added the status:under development Someone is working on a pull request. label Apr 22, 2021
Copy link
Member

@samdark samdark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks alright 👍 Need to test it more as end user.

@samdark samdark requested a review from a team April 23, 2021 22:32
@samdark samdark marked this pull request as ready for review April 23, 2021 22:32
@samdark
Copy link
Member

samdark commented Apr 23, 2021

Before merge need:

  1. Docs.
  2. Updates in app templates.

Copy link
Member

@terabytesoftw terabytesoftw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@terabytesoftw terabytesoftw requested a review from a team April 24, 2021 16:48
Copy link
Member

@roxblnfk roxblnfk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like that dist files is optional

@devanych devanych added status:code review The pull request needs review. and removed status:under development Someone is working on a pull request. labels Apr 26, 2021
@samdark samdark merged commit 718fba7 into master Apr 26, 2021
@samdark samdark deleted the improve-config-diff-logic branch April 26, 2021 12:07
@samdark
Copy link
Member

samdark commented Apr 26, 2021

Great job 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants