Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix psalm errors + Improve type hints + Add support of object arrays to IterableDataReader #113

Merged
merged 10 commits into from
Dec 27, 2022

Conversation

vjik
Copy link
Member

@vjik vjik commented Dec 25, 2022

Q A
Is bugfix? ✔️
New feature? ✔️
Breaks BC? ✔️
Fixed issues #107
  • fixed psalm errors
  • in with* methods change return type hint from self to static
  • add support of object arrays to IterableDataReader

@codecov
Copy link

codecov bot commented Dec 25, 2022

Codecov Report

Base: 99.35% // Head: 99.19% // Decreases project coverage by -0.16% ⚠️

Coverage data is based on head (52bdb1d) compared to base (d7acb58).
Patch coverage: 96.29% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #113      +/-   ##
============================================
- Coverage     99.35%   99.19%   -0.17%     
+ Complexity      258      254       -4     
============================================
  Files            35       36       +1     
  Lines           622      619       -3     
============================================
- Hits            618      614       -4     
- Misses            4        5       +1     
Impacted Files Coverage Δ
src/Paginator/OffsetPaginator.php 97.33% <ø> (ø)
src/Reader/Filter/GroupFilter.php 100.00% <ø> (ø)
.../Iterable/Processor/IterableProcessorInterface.php 0.00% <0.00%> (ø)
src/Paginator/KeysetPaginator.php 100.00% <100.00%> (ø)
src/Reader/Iterable/IterableDataReader.php 98.03% <100.00%> (ø)
src/Reader/Iterable/Processor/Between.php 100.00% <100.00%> (ø)
src/Reader/Iterable/Processor/CompareProcessor.php 100.00% <100.00%> (ø)
src/Reader/Iterable/Processor/EqualsEmpty.php 100.00% <100.00%> (ø)
src/Reader/Iterable/Processor/EqualsNull.php 100.00% <100.00%> (ø)
src/Reader/Iterable/Processor/GroupProcessor.php 100.00% <100.00%> (ø)
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vjik vjik changed the title Fix psalm errors + Improve type hints Fix psalm errors + Improve type hints + Add support of object arrays to IterableDataReader Dec 25, 2022
@vjik vjik requested a review from a team December 25, 2022 20:57
@vjik vjik added the status:code review The pull request needs review. label Dec 25, 2022
@vjik vjik merged commit d458436 into master Dec 27, 2022
@vjik vjik deleted the fix-psalm branch December 27, 2022 10:21
@vjik vjik mentioned this pull request Dec 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants