Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add getters' support #129

Merged
merged 5 commits into from
Jan 12, 2023
Merged

Add getters' support #129

merged 5 commits into from
Jan 12, 2023

Conversation

vjik
Copy link
Member

@vjik vjik commented Jan 10, 2023

Q A
Is bugfix? ❌
New feature? ✔️
Breaks BC? ❌
Fixed issues #127

@vjik vjik requested a review from a team January 10, 2023 18:05
@what-the-diff
Copy link

what-the-diff bot commented Jan 10, 2023

  • Update composer.json
  • Add DataHelper class to src/DataHelper.php
  • Replace ArrayHelper with DataHelper in KeysetPaginator and tests for it (src/Paginator/KeysetPaginator, tests\Reader\IterableHandler)
  • Fix some typos in docblocks of IterableFilterHandlerInterface and its implementations: Between, Compare, EqualsNull (src\Reader\Iterable)

@vjik vjik added the status:code review The pull request needs review. label Jan 10, 2023
samdark
samdark reviewed Jan 10, 2023
View reviewed changes
src/DataHelper.php Outdated Show resolved Hide resolved
src/DataHelper.php Outdated Show resolved Hide resolved
src/DataHelper.php Outdated Show resolved Hide resolved
@vjik vjik mentioned this pull request Jan 11, 2023
Closed
@samdark samdark added this to the 1.0.0 milestone Jan 11, 2023
@vjik
Use ArrayHelper
e0d822f
@vjik
Merge remote-tracking branch 'origin/master' into getters
74715ce 
# Conflicts:
#	tests/Reader/IterableHandler/BetweenTest.php
#	tests/Reader/IterableHandler/EqualsNullTest.php
#	tests/Reader/IterableHandler/EqualsTest.php
@codecov
Copy link

codecov bot commented Jan 12, 2023 •
edited
Loading

Codecov Report

Base: 99.35% // Head: 99.51% // Increases project coverage by +0.15% 🎉

Coverage data is based on head (4ee9023) compared to base (273064b).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@             Coverage Diff              @@
##             master     #129      +/-   ##
============================================
+ Coverage     99.35%   99.51%   +0.15%     
+ Complexity      252      249       -3     
============================================
  Files            35       35              
  Lines           620      615       -5     
============================================
- Hits            616      612       -4     
+ Misses            4        3       -1
Impacted Files Coverage Δ
src/Paginator/KeysetPaginator.php 100.00% <100.00%> (ø)
src/Reader/Iterable/IterableDataReader.php 99.07% <0.00%> (+0.92%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vjik vjik requested a review from samdark January 12, 2023 12:16
@samdark samdark merged commit 5c5da04 into master Jan 12, 2023
@samdark samdark deleted the getters branch January 12, 2023 19:09
@samdark
Copy link
Member

samdark commented Jan 12, 2023

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roxblnfk roxblnfk roxblnfk left review comments

@samdark samdark samdark approved these changes

Assignees
No one assigned
Labels
status:code review The pull request needs review.
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vjik @samdark @roxblnfk @StyleCIBot