-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reorganize tests #181
base: master
Are you sure you want to change the base?
Reorganize tests #181
Conversation
arogachev
commented
May 15, 2024
Q | A |
---|---|
Is bugfix? | ❌ |
New feature? | ❌ |
Breaks BC? | ❌ |
{ | ||
protected function getReader(): DataReaderInterface | ||
{ | ||
return new IterableDataReader(self::$fixtures); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IterableDataReader
is not common.
|
||
namespace Yiisoft\Data\Tests\Common; | ||
|
||
trait FixtureTrait |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do this trait need somewhere else besides readers?
public function testWithReader(): void | ||
{ | ||
$reader = $this | ||
->getReader() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion only...
Create abstract classes Base%Filter%WithReaderTest
with abstract method getReader()
and use FixtureTrait
.