Reorganize tests #181
Open
Reorganize tests #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
arogachev
commented
May 15, 2024
arogachev
commented
| Q | A |
|---|---|
| Is bugfix? | ❌ |
| New feature? | ❌ |
| Breaks BC? | ❌ |
samdark
approved these changes
May 22, 2024
vjik
reviewed
May 22, 2024
| { | ||
| protected function getReader(): DataReaderInterface | ||
| { | ||
| return new IterableDataReader(self::$fixtures); |
|
|
||
| namespace Yiisoft\Data\Tests\Common; | ||
|
|
||
| trait FixtureTrait |
There was a problem hiding this comment.
Do this trait need somewhere else besides readers?
| public function testWithReader(): void | ||
| { | ||
| $reader = $this | ||
| ->getReader() |
There was a problem hiding this comment.
Suggestion only...
Create abstract classes Base%Filter%WithReaderTest with abstract method getReader() and use FixtureTrait.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.