Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DataReaderInterface::readOne() #40

Merged
merged 2 commits into from Jun 29, 2020
Merged

Add DataReaderInterface::readOne() #40

merged 2 commits into from Jun 29, 2020

Conversation

roxblnfk
Copy link
Member

Q A
Is bugfix? ❌
New feature? ✔️
Breaks BC? ✔️/❌
Tests pass? ✔️
Fixed issues #39

@roxblnfk roxblnfk added the status:code review The pull request needs review. label Jun 29, 2020
@roxblnfk roxblnfk requested review from samdark and a team June 29, 2020 11:08
xepozz
xepozz reviewed Jun 29, 2020
View reviewed changes
Copy link
Contributor

@xepozz xepozz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's result expected when readOne() will be called two or more times?

src/Reader/Iterable/IterableDataReader.php Outdated Show resolved Hide resolved
@romkatsu romkatsu requested a review from a team June 29, 2020 16:34
@samdark
Copy link
Member

samdark commented Jun 29, 2020

@xepozz as far as I get it, it will be the same item all the time.

@samdark samdark merged commit d937aac into yiisoft:master Jun 29, 2020
@samdark
Copy link
Member

samdark commented Jun 29, 2020

👍

@roxblnfk roxblnfk deleted the feature/data-reader-read-one branch October 25, 2020 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xepozz xepozz xepozz left review comments

@romkatsu romkatsu romkatsu requested changes

@samdark samdark samdark approved these changes

Assignees
No one assigned
Labels
status:code review The pull request needs review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@roxblnfk @samdark @romkatsu @xepozz