Add filters of Between, EqualsEmpty and EqualsNull #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
devanych
commented
Feb 14, 2022
devanych
commented
| Q | A |
|---|---|
| Is bugfix? | ❌ |
| New feature? | ✔️ |
| Breaks BC? | ❌ |
| Fixed issues | #42 |
samdark
approved these changes
Feb 14, 2022
|
👍 |
roxblnfk
requested changes
Feb 15, 2022
| private function validateValue($value): void | ||
| { | ||
| if (!is_scalar($value)) { | ||
| throw new InvalidArgumentException(sprintf( |
There was a problem hiding this comment.
What about datetimeInterface?
Is it possible to support this?
There was a problem hiding this comment.
Yes, that would be great. @roxblnfk would you please add an issue about it?
There was a problem hiding this comment.
In the same filter? Or can create a separate BetweenDate class?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.