Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecesary SchemaCache::class. #196

Merged
merged 2 commits into from
Aug 30, 2023
Merged

Remove unnecesary SchemaCache::class. #196

merged 2 commits into from
Aug 30, 2023

Conversation

terabytesoftw
Copy link
Member

Q A
Is bugfix? ✔️
New feature?
Breaks BC?

@what-the-diff
Copy link

what-the-diff bot commented Aug 30, 2023

PR Summary

  • Removal of SchemaCache Import and Associated Methods in Migrator.php
    The import of SchemaCache which provides cached data for the schema was removed to streamline processes. The connected methods beforeMigrate() and afterMigrate() were also removed for simplification.

  • Updates to Test Methods in AbstractMigrationBuilderTest.php
    Several tests have been enhanced and modernized by swapping out the function getTableSchema('test', true) with getTableSchema('test') for these tests.

  • Removal of SchemaCache Import in AbstractMigratorTest.php
    Unnecessary import SchemaCache eliminated to make the file more efficient.

  • Updates to Code Statement in AbstractUpdateCommandTest.php
    The command to fetching foreign keys from 'student' was upgraded for better performance.

  • Optimization of getTableSchema Calls in MigrationBuilderTest.php
    Calls to manufacture table schemas in several driver-specific tests have been upgraded for better functioning.

  • OracleFactory.php Condition Update
    For the OracleFactory, a verification condition was updated to use the more efficient getTableSchema function.

  • Removal of SchemaCache Import in ContainerHelper.php
    The import of SchemaCache was removed from the get() method to streamline operation.

  • Update to getTableSchema Calls in DbHelper.php
    Calls in DbHelper.php to manufacture table schemas have been updated to use simpler and more efficient function calls.

@samdark samdark merged commit b9bb077 into master Aug 30, 2023
77 checks passed
@samdark samdark deleted the clean-code branch August 30, 2023 12:55
@samdark
Copy link
Member

samdark commented Aug 30, 2023

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants