Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove yiisoft/strings dependency #210

Merged
merged 3 commits into from
Oct 15, 2023
Merged

Conversation

Tigrov
Copy link
Member

@Tigrov Tigrov commented Oct 15, 2023

Q A
Is bugfix?
New feature?
Breaks BC?
Fixed issues -

@codecov
Copy link

codecov bot commented Oct 15, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (e8427c7) 99.78% compared to head (dbf5c19) 99.78%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #210   +/-   ##
=========================================
  Coverage     99.78%   99.78%           
- Complexity      276      277    +1     
=========================================
  Files            19       19           
  Lines           937      938    +1     
=========================================
+ Hits            935      936    +1     
  Misses            2        2           
Files Coverage Δ
src/Command/CreateCommand.php 100.00% <100.00%> (ø)
src/MigrationBuilder.php 100.00% <100.00%> (ø)
src/Service/MigrationService.php 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tigrov Tigrov marked this pull request as ready for review October 15, 2023 01:00
src/MigrationBuilder.php Outdated Show resolved Hide resolved
Tigrov and others added 2 commits October 15, 2023 13:46
Co-authored-by: Sergei Predvoditelev <sergei@predvoditelev.ru>
@vjik vjik merged commit 0e23a9f into master Oct 15, 2023
79 checks passed
@vjik vjik deleted the remove_yiisoft_strings_dependency branch October 15, 2023 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants