Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show count of applied migrations #217

Merged
merged 21 commits into from
Oct 18, 2023
Merged

Show count of applied migrations #217

merged 21 commits into from
Oct 18, 2023

Conversation

Tigrov
Copy link
Member

@Tigrov Tigrov commented Oct 17, 2023

Q A
Is bugfix? ❌
New feature? ✔️
Breaks BC? ❌
Fixed issues #23

@codecov
Copy link

codecov bot commented Oct 17, 2023 •
edited

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (176070a) 99.78% compared to head (23dc752) 99.79%.

Additional details and impacted files 
@@            Coverage Diff            @@
##             master     #217   +/-   ##
=========================================
  Coverage     99.78%   99.79%           
- Complexity      284      290    +6     
=========================================
  Files            19       19           
  Lines           939      957   +18     
=========================================
+ Hits            937      955   +18     
  Misses            2        2
Files Coverage Δ
src/Command/DownCommand.php 100.00% <100.00%> (ø)
src/Command/NewCommand.php 100.00% <100.00%> (ø)
src/Command/RedoCommand.php 100.00% <100.00%> (ø)
src/Command/UpdateCommand.php 100.00% <100.00%> (ø)
src/Migrator.php 100.00% <ø> (ø)
src/Service/MigrationService.php 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tigrov Tigrov marked this pull request as ready for review October 17, 2023 09:37
vjik
vjik requested changes Oct 17, 2023
View reviewed changes
Copy link
Member

@vjik vjik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To fix #23 need to do the same in DownCommand.

src/Command/UpdateCommand.php Outdated Show resolved Hide resolved
@vjik vjik merged commit 44f9ac4 into master Oct 18, 2023
79 checks passed
@vjik vjik deleted the show_count_when_exception branch October 18, 2023 07:09
@vjik vjik mentioned this pull request Oct 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vjik vjik vjik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Tigrov @vjik @StyleCIBot @samdark