Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better naming for column name #220

Merged
merged 2 commits into from
Oct 19, 2023
Merged

Better naming for column name #220

merged 2 commits into from
Oct 19, 2023

Conversation

Tigrov
Copy link
Member

@Tigrov Tigrov commented Oct 19, 2023

Q A
Is bugfix?
New feature?
Breaks BC?
Fixed issues -

@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (44f9ac4) 99.79% compared to head (a11f879) 99.79%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #220   +/-   ##
=========================================
  Coverage     99.79%   99.79%           
  Complexity      290      290           
=========================================
  Files            19       19           
  Lines           957      957           
=========================================
  Hits            955      955           
  Misses            2        2           
Files Coverage Δ
src/Service/Generate/Column.php 100.00% <100.00%> (ø)
src/Service/Generate/FieldsParser.php 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vjik vjik merged commit 024c175 into master Oct 19, 2023
79 checks passed
@vjik vjik deleted the better_naming_column_name branch October 19, 2023 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants