Clarify options on CreateCommand #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Tigrov
commented
Oct 19, 2023
Tigrov
commented
| Q | A |
|---|---|
| Is bugfix? | ❌ |
| New feature? | ❌ |
| Breaks BC? | ❌ |
| Fixed issues | - |
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #223 +/- ##
=========================================
Coverage 99.79% 99.79%
+ Complexity 290 288 -2
=========================================
Files 19 19
Lines 957 957
=========================================
Hits 955 955
Misses 2 2
☔ View full report in Codecov by Sentry. |
samdark
reviewed
Oct 19, 2023
Comment on lines
+81
to
+84
| ->addOption('command', 'c', InputOption::VALUE_REQUIRED, 'Command to execute.', 'create') | ||
| ->addOption('fields', 'f', InputOption::VALUE_REQUIRED, 'Table fields to generate.') | ||
| ->addOption('table-comment', null, InputOption::VALUE_REQUIRED, 'Table comment.') | ||
| ->addOption('and', null, InputOption::VALUE_REQUIRED, 'And junction.') |
There was a problem hiding this comment.
It means if you call the command with an option you should specify a value.
It makes no sense to call the command with these options without values.
e.g. ./yii migrate:create post --command
samdark
approved these changes
Oct 19, 2023
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.