Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename config options #247

Merged
merged 7 commits into from
Dec 21, 2023
Merged

Rename config options #247

merged 7 commits into from
Dec 21, 2023

Conversation

samdark
Copy link
Member

@samdark samdark commented Dec 21, 2023

Q A
Is bugfix? ✔️
New feature?
Breaks BC? ✔️

@samdark samdark requested a review from vjik December 21, 2023 12:39
Copy link

what-the-diff bot commented Dec 21, 2023

PR Summary

  • Parameter Renames for Clarity
    Several parameter names were updated for better clarity. The previous parameters createNamespace, createPath, updateNamespaces, and updatePaths, have been renamed as newMigrationNamespace, newMigrationPath, sourceNamespaces, and sourcePaths respectively.

  • Updates in MigrationService Class
    The MigrationService class has been revised to accommodate these new parameter names.

  • Documentation Updates
    The changes in parameter names were reflected in the documentation files usage-with-symfony.md and usage-with-yii-console.md.

  • Class Updates for New Parameter Names
    Classes CreateCommand, NewCommand, UpdateCommand, and MigrationService were updated to use the new parameter names.

  • Test Additions and Updates
    New tests were added and existing tests were updated for the CreateCommand, UpdateCommand, and MigrationService classes to ensure the codebase remains robust with these changes.

  • Method Name Updates for Consistency
    In line with the parameter renaming, certain method names were also updated: setCreatePath and setUpdatePaths are now setNewMigrationPath and setSourcePaths respectively, and setCreateNamespace and setUpdateNamespaces have been changed to setNewMigrationNamespace and setSourceNamespaces respectively.

  • Updated Method Calls
    Method calls have been updated to reference the new method names, such as migrating from $migrationService->getCreateNamespace() to $migrationService->getNewMigrationNamespace().

config/params.php Outdated Show resolved Hide resolved
Copy link

codecov bot commented Dec 21, 2023

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (e0e4e49) 97.34% compared to head (cdcc28a) 97.34%.

Files Patch % Lines
config/di-console.php 0.00% 4 Missing ⚠️
config/params.php 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master     #247   +/-   ##
=========================================
  Coverage     97.34%   97.34%           
  Complexity      313      313           
=========================================
  Files            21       21           
  Lines          1055     1055           
=========================================
  Hits           1027     1027           
  Misses           28       28           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@arogachev arogachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are not passing.

@samdark
Copy link
Member Author

samdark commented Dec 21, 2023

@arogachev fixed.

@vjik vjik merged commit f99d3b3 into master Dec 21, 2023
78 of 79 checks passed
@vjik vjik deleted the rename-config branch December 21, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants