Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix psalm issues #292

Merged
merged 10 commits into from
Feb 3, 2024
Merged

Fix psalm issues #292

merged 10 commits into from
Feb 3, 2024

Conversation

Tigrov
Copy link
Member

@Tigrov Tigrov commented Jan 29, 2024

Q A
Is bugfix?
New feature?
Breaks BC?
Fixed issues -

Copy link

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2964f96) 98.01% compared to head (e7506eb) 98.01%.

❗ Current head e7506eb differs from pull request most recent head 82cbc83. Consider uploading reports for the commit 82cbc83 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #292   +/-   ##
=========================================
  Coverage     98.01%   98.01%           
  Complexity      208      208           
=========================================
  Files            15       15           
  Lines           604      604           
=========================================
  Hits            592      592           
  Misses           12       12           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

what-the-diff bot commented Jan 29, 2024

PR Summary

  • Enhanced Safety in Command File
    Additional checks have been implemented in the Command.php file to verify if the table schema and primary keys are defined before proceeding with any operations.
  • Improved Null Check in DDLQueryBuilder
    More stringent null-checks have been added to the DDLQueryBuilder.php file for increased safety during query building phase.
  • Upgraded Dsn File Safety Measures
    The Dsn.php file now includes an extra layer of validation to ensure a non-empty, non-null database name before initiating any kind of actions.
  • Added Quantity Validation in DMLQueryBuilder and Quoter
    Both DMLQueryBuilder.php and Quoter.php files now tend to check for more than zero entries before execution for better efficiency.
  • Enhanced Null Check in Schema
    The Schema.php file now employs more rigorous null-checks to increase overall system stability.

@Tigrov Tigrov added the status:code review The pull request needs review. label Jan 30, 2024
CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Sergei Predvoditelev <sergei@predvoditelev.ru>
@vjik vjik merged commit ff10686 into master Feb 3, 2024
3 checks passed
@vjik vjik deleted the fix-psalm-issues branch February 3, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants