Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insert ex #149

Merged
merged 2 commits into from
Jan 6, 2023
Merged

Insert ex #149

merged 2 commits into from
Jan 6, 2023

Conversation

darkdef
Copy link
Contributor

@darkdef darkdef commented Jan 6, 2023

Q A
Is bugfix?
New feature?
Breaks BC?

@what-the-diff
Copy link

what-the-diff bot commented Jan 6, 2023

  • Removed queryBuilder() method
  • Added insertWithReturningPks() method
  • Moved queryBuilder() to the end of class definition (after all other methods)

@codecov
Copy link

codecov bot commented Jan 6, 2023

Codecov Report

Base: 98.02% // Head: 98.02% // No change to project coverage 👍

Coverage data is based on head (4d5ca78) compared to base (cea9688).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #149   +/-   ##
=========================================
  Coverage     98.02%   98.02%           
  Complexity      196      196           
=========================================
  Files            16       16           
  Lines           607      607           
=========================================
  Hits            595      595           
  Misses           12       12           
Impacted Files Coverage Δ
src/CommandPDO.php 98.41% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@darkdef darkdef merged commit e0d8783 into yiisoft:master Jan 6, 2023
@darkdef darkdef deleted the insert_ex branch January 6, 2023 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants