Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use prefix Abstract in class in src/Schema. #151

Closed
wants to merge 4 commits into from

Conversation

terabytesoftw
Copy link
Member

Q A
Is bugfix? ✔️
New feature?
Breaks BC?

@what-the-diff
Copy link

what-the-diff bot commented Jan 9, 2023

  • Rename ColumnSchema to AbstractColumnSchema
  • Rename Quoter to AbstractQuoter
  • Rename Schema to AbstractSchema
  • Remove unused class TableBuilder and rename TableSchemea as well

@codecov
Copy link

codecov bot commented Jan 9, 2023

Codecov Report

Base: 98.02% // Head: 98.02% // No change to project coverage 👍

Coverage data is based on head (eda8522) compared to base (590202f).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #151   +/-   ##
=========================================
  Coverage     98.02%   98.02%           
  Complexity      196      196           
=========================================
  Files            16       16           
  Lines           607      607           
=========================================
  Hits            595      595           
  Misses           12       12           
Impacted Files Coverage Δ
src/ColumnSchema.php 100.00% <ø> (ø)
src/ColumnSchemaBuilder.php 100.00% <ø> (ø)
src/CommandPDO.php 98.41% <ø> (ø)
src/QueryBuilder.php 100.00% <ø> (ø)
src/Quoter.php 100.00% <ø> (ø)
src/Schema.php 99.61% <ø> (ø)
src/TableSchema.php 100.00% <ø> (ø)
src/DDLQueryBuilder.php 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@terabytesoftw terabytesoftw added the status:code review The pull request needs review. label Jan 9, 2023
@terabytesoftw terabytesoftw deleted the better-naming-schema branch January 30, 2023 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant