Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support all versions pg-sql. #29

Merged
merged 22 commits into from Aug 21, 2020
Merged

Add support all versions pg-sql. #29

merged 22 commits into from Aug 21, 2020

Conversation

terabytesoftw
Copy link
Member

Q A
Is bugfix? ✔️
New feature?
Breaks BC?
Fixed issues yiisoft/yii2#15265, yiisoft/yii2#18232

@terabytesoftw terabytesoftw added the status:code review The pull request needs review. label Aug 17, 2020
Copy link
Member

@samdark samdark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall 👍

.github/workflows/build.yml Outdated Show resolved Hide resolved
phpunit.xml.dist Outdated Show resolved Hide resolved
@samdark samdark added status:ready for merge The pull request is OK to be merged. and removed status:code review The pull request needs review. labels Aug 17, 2020
src/Expression/ArrayExpressionBuilder.php Outdated Show resolved Hide resolved
src/Query/QueryBuilder.php Outdated Show resolved Hide resolved
src/Query/QueryBuilder.php Outdated Show resolved Hide resolved
src/Schema/Schema.php Outdated Show resolved Hide resolved
tests/data/docker/10/docker-compose.yml Outdated Show resolved Hide resolved
tests/data/docker/9/docker-compose.yml Outdated Show resolved Hide resolved
@samdark
Copy link
Member

samdark commented Aug 18, 2020

It's not easy to review the pull request with all these function imports made. It's better to do such changes separately.

@samdark samdark added status:under development Someone is working on a pull request. and removed status:ready for merge The pull request is OK to be merged. labels Aug 18, 2020
@terabytesoftw terabytesoftw added status:code review The pull request needs review. and removed status:under development Someone is working on a pull request. labels Aug 19, 2020
Copy link
Member

@samdark samdark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks alright. Can be either merged or worked further to fix static analysis issues... What do you prefer?

composer.json Outdated Show resolved Hide resolved
@terabytesoftw terabytesoftw merged commit eecb1bc into yiisoft:master Aug 21, 2020
@terabytesoftw terabytesoftw deleted the add-support-versions branch August 21, 2020 14:01
@samdark
Copy link
Member

samdark commented Aug 21, 2020

👍

devanych pushed a commit that referenced this pull request Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants