Update rector/rector dependency + Enable rector CI and apply suggesti…

…ons (#256)
yiisoft · May 8, 2023 · 8b83434 · 8b83434
1 parent 5f0b18c
commit 8b83434
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 15 deletions.
diff --git a/.github/workflows/rector.yml_ → .github/workflows/rector.yml b/.github/workflows/rector.yml_ → .github/workflows/rector.yml
diff --git a/composer.json b/composer.json
@@ -30,7 +30,7 @@
         "ext-json": "*",
         "maglnet/composer-require-checker": "^4.2",
         "phpunit/phpunit": "^9.6|^10.0",
-        "rector/rector": "^0.14",
+        "rector/rector": "^0.16",
         "roave/infection-static-analysis-plugin": "^1.16",
         "spatie/phpunit-watcher": "^1.23",
         "vimeo/psalm": "^4.3|^5.6",

diff --git a/src/Schema.php b/src/Schema.php
@@ -604,8 +604,6 @@ private function loadTableConstraints(string $tableName, string $returnType): Co
      * This method may be overridden by child classes to create a DBMS-specific column schema.
      *
      * @param string $name Name of the column.
-     *
-     * @return ColumnSchemaInterface
      */
     private function createColumnSchema(string $name): ColumnSchemaInterface
     {

diff --git a/src/Transaction.php b/src/Transaction.php
@@ -33,17 +33,12 @@ final class Transaction extends AbstractPdoTransaction
      */
     protected function setTransactionIsolationLevel(string $level): void
     {
-        switch ($level) {
-            case self::SERIALIZABLE:
-                $this->db->createCommand('PRAGMA read_uncommitted = False;')->execute();
-                break;
-            case self::READ_UNCOMMITTED:
-                $this->db->createCommand('PRAGMA read_uncommitted = True;')->execute();
-                break;
-            default:
-                throw new NotSupportedException(
-                    self::class . ' only supports transaction isolation levels READ UNCOMMITTED and SERIALIZABLE.'
-                );
-        }
+        match ($level) {
+            self::SERIALIZABLE => $this->db->createCommand('PRAGMA read_uncommitted = False;')->execute(),
+            self::READ_UNCOMMITTED => $this->db->createCommand('PRAGMA read_uncommitted = True;')->execute(),
+            default => throw new NotSupportedException(
+                self::class . ' only supports transaction isolation levels READ UNCOMMITTED and SERIALIZABLE.'
+            ),
+        };
     }
 }