Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix psalm issues. #182

Merged
merged 3 commits into from
Oct 9, 2020
Merged

Fix psalm issues. #182

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e3699b6
Fix psalm issues.
terabytesoftw Oct 9, 2020
2964a5a
Fix minor correction.
terabytesoftw Oct 9, 2020
15cc85a
Remove unnecessary phpdoc.
terabytesoftw Oct 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/Schema/Schema.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,8 @@ public function __construct(ConnectionInterface $db)
$this->cache = $this->db->getSchemaCache();
}

abstract public function createQueryBuilder(): QueryBuilder;

/**
* Resolves the table name and schema name (if any).
*
Expand All @@ -122,11 +124,11 @@ protected function resolveTableName(string $name): TableSchema
* This method should be overridden by child classes in order to support this feature because the default
* implementation simply throws an exception.
*
* @return void all schema names in the database, except system schemas.
* @return array all schema names in the database, except system schemas.
*
* @throws NotSupportedException if this method is not supported by the DBMS.
*/
protected function findSchemaNames()
protected function findSchemaNames(): array
{
throw new NotSupportedException(get_class($this) . ' does not support fetching all schema names.');
}
Expand All @@ -139,7 +141,7 @@ protected function findSchemaNames()
*
* @param string $schema the schema of the tables. Defaults to empty string, meaning the current or default schema.
*
* @return void all table names in the database. The names have NO schema name prefix.
* @return array all table names in the database. The names have NO schema name prefix.
*
* @throws NotSupportedException if this method is not supported by the DBMS.
*/
Expand Down