Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build union and order limit. #709

Closed
wants to merge 1 commit into from

Conversation

terabytesoftw
Copy link
Member

Q A
Is bugfix? ✔️
New feature?
Breaks BC?
Fixed issues #81

@terabytesoftw terabytesoftw linked an issue Apr 17, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Apr 17, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.07 ⚠️

Comparison is base (04cc4e4) 99.83% compared to head (bcb07fb) 99.77%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #709      +/-   ##
============================================
- Coverage     99.83%   99.77%   -0.07%     
  Complexity     1286     1286              
============================================
  Files            63       63              
  Lines          3057     3059       +2     
============================================
  Hits           3052     3052              
- Misses            5        7       +2     
Impacted Files Coverage Δ
src/QueryBuilder/AbstractDQLQueryBuilder.php 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@samdark
Copy link
Member

samdark commented Apr 17, 2023

I think we need tests that ensure correct order.

@vjik
Copy link
Member

vjik commented Apr 19, 2023

Need changelog.

@terabytesoftw terabytesoftw deleted the fix-issue-build-union-and-order-limit branch July 13, 2023 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

QueryBuilder: union and order by not works
3 participants