Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NotFoundException is not a scope of a definition #5

Closed
yiiliveext opened this issue Aug 31, 2021 · 0 comments
Closed

NotFoundException is not a scope of a definition #5

yiiliveext opened this issue Aug 31, 2021 · 0 comments
Assignees
@samdark
Labels
status:ready for adoption Feel free to implement this issue.

Comments

@yiiliveext
Copy link
Contributor

yiiliveext commented Aug 31, 2021 •
edited by samdark

In this case https://github.com/yiisoft/definitions/blob/master/src/Infrastructure/DefinitionExtractor.php#L57, we shouldn't throw NotFoundExeption because this exception is a scope of a container. Use NotInstantiableClassException instead. Also, I think we should move NotFoundException to a container and factory.
@samdark samdark added the status:ready for adoption Feel free to implement this issue. label Sep 8, 2021
@samdark samdark self-assigned this Nov 18, 2021
samdark added a commit that referenced this issue Nov 18, 2021
@samdark
Fix #5: Adjust exception type
c104160
@samdark samdark mentioned this issue Nov 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samdark samdark

Labels
status:ready for adoption Feel free to implement this issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@samdark @yiiliveext