Skip to content
This repository has been archived by the owner on Nov 20, 2022. It is now read-only.

Add translator #115

Merged
merged 3 commits into from
Nov 6, 2022
Merged

Add translator #115

merged 3 commits into from
Nov 6, 2022

Conversation

xepozz
Copy link
Contributor

@xepozz xepozz commented Nov 5, 2022

Q A
Is bugfix? ✔️
New feature? ✔️
Breaks BC? ❌

@xepozz xepozz added the status:code review The pull request needs review. label Nov 5, 2022
@xepozz xepozz requested a review from a team November 5, 2022 18:35
@what-the-diff
Copy link

what-the-diff bot commented Nov 5, 2022

  • Added locale middleware
  • Added translation support for application messages
  • Updated 404 handler to use translated message instead of hardcoded one
  • Fixed tests to check that correct error message is returned in response body and it's localized correctly

vjik
vjik approved these changes Nov 6, 2022
View reviewed changes
config/common/router.php Outdated Show resolved Hide resolved
@samdark @vjik
Update config/common/router.php
47335ea 
Co-authored-by: Sergei Predvoditelev <sergei@predvoditelev.ru>
@samdark samdark merged commit bb06345 into master Nov 6, 2022
@samdark
Copy link
Member

samdark commented Nov 6, 2022

👍

@samdark samdark deleted the add-translator branch November 6, 2022 07:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@samdark samdark samdark approved these changes

@vjik vjik vjik approved these changes

Assignees
No one assigned
Labels
status:code review The pull request needs review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xepozz @samdark @vjik