Add test with optional dependency (#292)

yiisoft · Dec 19, 2021 · 243b24a · 243b24a
1 parent a2fa580
commit 243b24a
Show file tree

Hide file tree

Showing 2 changed files with 44 additions and 1 deletion.
diff --git a/tests/Support/OptionalConcreteDependency.php b/tests/Support/OptionalConcreteDependency.php
@@ -0,0 +1,20 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Yiisoft\Di\Tests\Support;
+
+class OptionalConcreteDependency
+{
+    private ?Car $car;
+
+    public function __construct(Car $car = null)
+    {
+        $this->car = $car;
+    }
+
+    public function getCar(): ?Car
+    {
+        return $this->car;
+    }
+}
diff --git a/tests/Unit/ContainerTest.php b/tests/Unit/ContainerTest.php
@@ -36,6 +36,8 @@
 use Yiisoft\Di\Tests\Support\Garage;
 use Yiisoft\Di\Tests\Support\InvokeableCarFactory;
 use Yiisoft\Di\Tests\Support\MethodTestClass;
+use Yiisoft\Di\Tests\Support\NullableConcreteDependency;
+use Yiisoft\Di\Tests\Support\OptionalConcreteDependency;
 use Yiisoft\Di\Tests\Support\PropertyTestClass;
 use Yiisoft\Di\Tests\Support\SportCar;
 use Yiisoft\Di\Tests\Support\TreeItem;
@@ -44,7 +46,6 @@
 use Yiisoft\Di\Tests\Support\UnionTypeInConstructorParamNotResolvable;
 use Yiisoft\Di\Tests\Support\UnionTypeInConstructorFirstTypeInParamResolvable;
 use Yiisoft\Di\Tests\Support\VariadicConstructor;
-use Yiisoft\Di\Tests\Support\NullableConcreteDependency;
 use Yiisoft\Definitions\DynamicReference;
 use Yiisoft\Definitions\Exception\CircularReferenceException;
 use Yiisoft\Definitions\Exception\InvalidConfigException;
@@ -93,6 +94,28 @@ public function testNullableClassDependency(): void
         $container->get(NullableConcreteDependency::class);
     }
 
+    public function testOptionalResolvableClassDependency(): void
+    {
+        $container = new Container(
+            ContainerConfig::create()->withDefinitions([
+                EngineInterface::class => EngineMarkOne::class,
+            ])
+        );
+
+        $this->assertTrue($container->has(OptionalConcreteDependency::class));
+        $service = $container->get(OptionalConcreteDependency::class);
+        $this->assertInstanceOf(Car::class, $service->getCar());
+    }
+
+    public function testOptionalNotResolvableClassDependency(): void
+    {
+        $container = new Container(ContainerConfig::create());
+
+        $this->assertTrue($container->has(OptionalConcreteDependency::class));
+        $service = $container->get(OptionalConcreteDependency::class);
+        $this->assertNull($service->getCar());
+    }
+
     public function testOptionalCircularClassDependency(): void
     {
         $config = ContainerConfig::create()