Use Chicken and Egg instead of C and D

yiisoft · Jun 14, 2019 · 34549b1 · 34549b1
1 parent 8adf2c4
commit 34549b1
Show file tree

Hide file tree

Showing 5 changed files with 23 additions and 34 deletions.
diff --git a/tests/support/C.php b/tests/support/C.php
diff --git a/tests/support/D.php b/tests/support/D.php
diff --git a/tests/support/cycle/Chicken.php b/tests/support/cycle/Chicken.php
@@ -0,0 +1,9 @@
+<?php
+namespace yii\di\tests\support\cycle;
+
+class Chicken
+{
+    public function __construct(Egg $egg)
+    {
+    }
+}
diff --git a/tests/support/cycle/Egg.php b/tests/support/cycle/Egg.php
@@ -0,0 +1,9 @@
+<?php
+namespace yii\di\tests\support\cycle;
+
+class Egg
+{
+    public function __construct(Chicken $chicken)
+    {
+    }
+}
diff --git a/tests/unit/ContainerTest.php b/tests/unit/ContainerTest.php
@@ -12,16 +12,15 @@
 use yii\di\Reference;
 use yii\di\tests\support\A;
 use yii\di\tests\support\B;
-use yii\di\tests\support\C;
 use yii\di\tests\support\Car;
 use yii\di\tests\support\CarFactory;
 use yii\di\tests\support\ColorPink;
 use yii\di\tests\support\ConstructorTestClass;
-use yii\di\tests\support\D;
+use yii\di\tests\support\cycle\Chicken;
+use yii\di\tests\support\cycle\Egg;
 use yii\di\tests\support\EngineInterface;
 use yii\di\tests\support\EngineMarkOne;
 use yii\di\tests\support\EngineMarkTwo;
-use yii\di\tests\support\GearBox;
 use yii\di\tests\support\InvokeableCarFactory;
 use yii\di\tests\support\MethodTestClass;
 use yii\di\tests\support\PropertyTestClass;
@@ -67,10 +66,10 @@ public function testOptionalCircularClassDependency(): void
     public function testCircularClassDependency(): void
     {
         $container = new Container();
-        $container->set(C::class, C::class);
-        $container->set(D::class, D::class);
+        $container->set(Chicken::class, Chicken::class);
+        $container->set(Egg::class, Egg::class);
         $this->expectException(CircularReferenceException::class);
-        $container->get(C::class);
+        $container->get(Chicken::class);
     }
 
     public function testClassSimple(): void