Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change protected methods to private #245

Merged
merged 1 commit into from
Aug 17, 2021
Merged

Conversation

Nex-Otaku
Copy link
Contributor

Methods must be private because Container class is final and cannot be inherited

Q A
Is bugfix? No
New feature? No
Breaks BC? No
Fixed issues -

Container is final class, hence the method cannot be used in child classes and must be private instead of protected
@samdark samdark merged commit e4336ab into yiisoft:master Aug 17, 2021
@samdark
Copy link
Member

samdark commented Aug 17, 2021

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants