Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add psalm annotation for type hint returned object of Factory::create() #119

Merged
merged 1 commit into from
Aug 2, 2021
Merged

Add psalm annotation for type hint returned object of Factory::create() #119

merged 1 commit into from
Aug 2, 2021

Conversation

vjik
Copy link
Member

@vjik vjik commented Aug 2, 2021

Q A
Is bugfix? ❌
New feature? ❌
Breaks BC? ❌
Fixed issues #117

@vjik vjik added the status:code review The pull request needs review. label Aug 2, 2021
@vjik vjik requested a review from a team August 2, 2021 10:11
@samdark samdark merged commit 4c38df1 into master Aug 2, 2021
@samdark samdark deleted the psalm branch August 2, 2021 12:52
@samdark
Copy link
Member

samdark commented Aug 2, 2021

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
status:code review The pull request needs review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vjik @samdark