Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add scalars in constructor test #28

Closed
wants to merge 6 commits into from
Closed

Add scalars in constructor test #28

wants to merge 6 commits into from

Conversation

samdark
Copy link
Member

@samdark samdark commented Jun 28, 2020

Q A
Is bugfix? ❌
New feature? ❌
Breaks BC? ❌
Tests pass? ❌
Fixed issues -

@samdark samdark mentioned this pull request Jun 28, 2020
Merged
viktorprogger
viktorprogger requested changes Jun 29, 2020
View reviewed changes
tests/Unit/AbstractFactoryTest.php Outdated Show resolved Hide resolved
@viktorprogger
Copy link
Contributor

viktorprogger commented Jun 29, 2020 •
edited
Loading

Does it make sence to test default values (including overriding), named parameters and non-existent parameter values?

@vjik
Copy link
Member

vjik commented Jul 29, 2021

Seems this PR can be closed. We have similar tests, for example:

factory/tests/Unit/FactoryTest.php

Line 220 in 2dd1156

public function testCreateWithCallableValuesInConstructor(): void

@samdark samdark closed this Jul 29, 2021
@samdark samdark deleted the test-scalars branch July 29, 2021 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viktorprogger viktorprogger viktorprogger requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@samdark @viktorprogger @vjik