Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support "Stringable" as content in some methods of "Html" #70

Merged
merged 2 commits into from
Apr 26, 2021
Merged

Add support "Stringable" as content in some methods of "Html" #70

merged 2 commits into from
Apr 26, 2021

Conversation

vjik
Copy link
Member

@vjik vjik commented Apr 26, 2021 •
edited
Loading

Q A
Is bugfix? ❌
New feature? ✔️
Breaks BC? ✔️
Fixed issues -

This PR break BC. For example:

Before:

// <div>&lt;br&gt;</div>
Html::div(Html::br());

After:

// <div><br></div>
Html::div(Html::br());

@vjik vjik added the status:code review The pull request needs review. label Apr 26, 2021
@vjik vjik requested a review from a team April 26, 2021 13:27
@samdark
Copy link
Member

samdark commented Apr 26, 2021

I've enabled BC check for this repo.

@samdark
Copy link
Member

samdark commented Apr 26, 2021

And it's OK to relax type hint.

@samdark samdark merged commit 5d05f39 into master Apr 26, 2021
@samdark samdark deleted the html-tag-content branch April 26, 2021 14:04
@samdark
Copy link
Member

samdark commented Apr 26, 2021

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
status:code review The pull request needs review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vjik @samdark