Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix order attributes. #83

Merged
merged 3 commits into from
Aug 17, 2021
Merged

Fix order attributes. #83

merged 3 commits into from
Aug 17, 2021

Conversation

terabytesoftw
Copy link
Member

@terabytesoftw terabytesoftw commented Aug 17, 2021 •
edited
Loading

Q A
Is bugfix? ✔️
New feature? ❌
Breaks BC? ❌

Order correct:

<input type="email" id="attributesvalidatorform-email" name="AttributesValidatorForm[email]" value="" maxlength="20" minlength="8" required>

Current Order:

<input type="email" id="attributesvalidatorform-email" name="AttributesValidatorForm[email]" value="" maxlength="20" required minlength="8">

The minlength attribute must be added since the validator HasLength::class adds it, it is also common to use it with maxlength.

@terabytesoftw terabytesoftw added the status:code review The pull request needs review. label Aug 17, 2021
@vjik
Copy link
Member

vjik commented Aug 17, 2021

Need changelog

@terabytesoftw
Copy link
Member Author

Need changelog

Done.

@samdark samdark merged commit da39ca1 into yiisoft:master Aug 17, 2021
@samdark
Copy link
Member

samdark commented Aug 17, 2021

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samdark samdark samdark approved these changes

@vjik vjik vjik approved these changes

Assignees
No one assigned
Labels
status:code review The pull request needs review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@terabytesoftw @vjik @samdark