Remove unnecessary check in ContainerAttributeResolverFactory (#58)

yiisoft · Oct 25, 2023 · 4460cf7 · 4460cf7
1 parent 0429b31
commit 4460cf7
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 17 deletions.
diff --git a/src/AttributeHandling/ResolverFactory/AttributeResolverFactoryInterface.php b/src/AttributeHandling/ResolverFactory/AttributeResolverFactoryInterface.php
@@ -13,5 +13,5 @@ interface AttributeResolverFactoryInterface
     /**
      * @throws AttributeResolverNonInstantiableException
      */
-    public function create(DataAttributeInterface|ParameterAttributeInterface $attribute): object;
+    public function create(DataAttributeInterface|ParameterAttributeInterface $attribute): mixed;
 }
diff --git a/src/AttributeHandling/ResolverFactory/ContainerAttributeResolverFactory.php b/src/AttributeHandling/ResolverFactory/ContainerAttributeResolverFactory.php
@@ -4,14 +4,12 @@
 
 namespace Yiisoft\Hydrator\AttributeHandling\ResolverFactory;
 
-use LogicException;
 use Psr\Container\ContainerExceptionInterface;
 use Psr\Container\ContainerInterface;
 use Yiisoft\Hydrator\Attribute\Data\DataAttributeInterface;
 use Yiisoft\Hydrator\AttributeHandling\Exception\AttributeResolverNonInstantiableException;
 use Yiisoft\Hydrator\Attribute\Parameter\ParameterAttributeInterface;
 
-use function is_object;
 use function is_string;
 
 final class ContainerAttributeResolverFactory implements AttributeResolverFactoryInterface
@@ -27,7 +25,7 @@ public function __construct(
     /**
      * @throws ContainerExceptionInterface
      */
-    public function create(DataAttributeInterface|ParameterAttributeInterface $attribute): object
+    public function create(DataAttributeInterface|ParameterAttributeInterface $attribute): mixed
     {
         $resolver = $attribute->getResolver();
         if (!is_string($resolver)) {
@@ -43,18 +41,6 @@ public function create(DataAttributeInterface|ParameterAttributeInterface $attri
             );
         }
 
-        $result = $this->container->get($resolver);
-
-        if (!is_object($result)) {
-            throw new LogicException(
-                sprintf(
-                    'Resolver "%s" must be an object, "%s" given.',
-                    $resolver,
-                    get_debug_type($result),
-                ),
-            );
-        }
-
-        return $result;
+        return $this->container->get($resolver);
     }
 }