Improve Map attribute tests (#23)

yiisoft · May 25, 2023 · fcebe68 · fcebe68
1 parent e392eb6
commit fcebe68
Show file tree

Hide file tree

Showing 5 changed files with 3 additions and 41 deletions.
diff --git a/tests/Attribute/Data/MapTest.php b/tests/Attribute/Data/MapTest.php
@@ -22,7 +22,7 @@ public function testBase(): void
     {
         $hydrator = new Hydrator(new SimpleContainer());
 
-        $object = $hydrator->create(MapClass::class);
+        $object = $hydrator->create(MapClass::class, ['x' => 1, 'y' => 2]);
 
         $this->assertSame('1', $object->a);
         $this->assertSame('2', $object->b);
@@ -32,7 +32,7 @@ public function testStrict(): void
     {
         $hydrator = new Hydrator(new SimpleContainer());
 
-        $object = $hydrator->create(MapStrictClass::class);
+        $object = $hydrator->create(MapStrictClass::class, ['a' => 1, 'y' => 2, 'c' => 3]);
 
         $this->assertSame('1', $object->a);
         $this->assertSame('2', $object->b);
@@ -43,7 +43,7 @@ public function testNonStrict(): void
     {
         $hydrator = new Hydrator(new SimpleContainer());
 
-        $object = $hydrator->create(MapNonStrictClass::class, strict: true);
+        $object = $hydrator->create(MapNonStrictClass::class, ['a' => 1, 'y' => 2, 'c' => 3], strict: true);
 
         $this->assertSame('1', $object->a);
         $this->assertSame('2', $object->b);

diff --git a/tests/Support/Classes/MapClass.php b/tests/Support/Classes/MapClass.php
@@ -5,12 +5,7 @@
 namespace Yiisoft\Hydrator\Tests\Support\Classes;
 
 use Yiisoft\Hydrator\Attribute\Data\Map;
-use Yiisoft\Hydrator\Tests\Support\CustomData;
 
-#[CustomData([
-    'x' => 1,
-    'y' => 2,
-])]
 #[Map([
     'a' => 'x',
     'b' => 'y',

diff --git a/tests/Support/Classes/MapNonStrictClass.php b/tests/Support/Classes/MapNonStrictClass.php
@@ -5,9 +5,7 @@
 namespace Yiisoft\Hydrator\Tests\Support\Classes;
 
 use Yiisoft\Hydrator\Attribute\Data\Map;
-use Yiisoft\Hydrator\Tests\Support\CustomData;
 
-#[CustomData(['a' => 1, 'y' => 2, 'c' => 3])]
 #[Map(['b' => 'y'], false)]
 final class MapNonStrictClass
 {

diff --git a/tests/Support/Classes/MapStrictClass.php b/tests/Support/Classes/MapStrictClass.php
@@ -5,9 +5,7 @@
 namespace Yiisoft\Hydrator\Tests\Support\Classes;
 
 use Yiisoft\Hydrator\Attribute\Data\Map;
-use Yiisoft\Hydrator\Tests\Support\CustomData;
 
-#[CustomData(['a' => 1, 'y' => 2, 'c' => 3])]
 #[Map(['a' => 'a', 'b' => 'y'], true)]
 final class MapStrictClass
 {

diff --git a/tests/Support/CustomData.php b/tests/Support/CustomData.php