Update vimeo/psalm version + Fix BC checker (#74)

Co-authored-by: Sergei Predvoditelev <sergei@predvoditelev.ru>

.github/workflows/bc.yml

@@ -1,15 +1,14 @@
 on:
-  pull_request:
-  push:
+  - pull_request
+  - push
 
 name: backwards compatibility
+
 jobs:
   roave_bc_check:
-    name: Roave BC Check
-    runs-on: ubuntu-latest
-    steps:
-      - uses: actions/checkout@master
-      - name: fetch tags
-        run: git fetch --depth=1 origin +refs/tags/*:refs/tags/*
-      - name: Roave BC Check
-        uses: docker://nyholm/roave-bc-check-ga
+    uses: yiisoft/actions/.github/workflows/bc.yml@master
+    with:
+      os: >-
+        ['ubuntu-latest']
+      php: >-
+        ['8.0']

composer.json

@@ -29,7 +29,7 @@
         "phpunit/phpunit": "^9.5",
         "roave/infection-static-analysis-plugin": "^1.16",
         "spatie/phpunit-watcher": "^1.23",
-        "vimeo/psalm": "^4.18",
+        "vimeo/psalm": "^4.30|^5.7",
         "yiisoft/test-support": "^1.2"
     },
     "autoload": {

psalm.xml

@@ -1,6 +1,8 @@
 <?xml version="1.0"?>
 <psalm
     errorLevel="1"
+    findUnusedBaselineEntry="true"
+    findUnusedCode="false"
     xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
     xmlns="https://getpsalm.org/schema/config"
     xsi:schemaLocation="https://getpsalm.org/schema/config vendor/vimeo/psalm/config.xsd"

src/ArgumentException.php

@@ -21,6 +21,9 @@
 
 abstract class ArgumentException extends \InvalidArgumentException
 {
+    /**
+     * @var string
+     */
     protected const EXCEPTION_MESSAGE = 'Something is wrong with argument "%s" when calling "%s"%s.';
 
     public function __construct(ReflectionFunctionAbstract $reflection, string $parameter)

src/ResolvingState.php

@@ -62,6 +62,7 @@ public function disablePushTrailingArguments(bool $condition): void
      */
     public function addResolvedValue(&$value): void
     {
+        /** @psalm-suppress UnsupportedReferenceUsage */
         $this->resolvedValues[] = &$value;
     }
 
@@ -157,6 +158,7 @@ private function sortArguments(array $arguments): void
                 if (!is_object($value)) {
                     throw new InvalidArgumentException($this->reflection, (string)$key);
                 }
+                /** @psalm-suppress UnsupportedReferenceUsage */
                 $this->numericArguments[] = &$value;
             } else {
                 $this->namedArguments[$key] = &$value;