Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for invokable class name & request handler #89

Merged
merged 4 commits into from
Sep 19, 2023
Merged

Conversation

rustamwin
Copy link
Member

Q A
Is bugfix? ✔️/❌
New feature? ✔️/❌
Breaks BC?
Fixed issues #85

@rustamwin rustamwin added the status:code review The pull request needs review. label Sep 16, 2023
@rustamwin rustamwin requested a review from a team September 16, 2023 06:31
@codecov
Copy link

codecov bot commented Sep 16, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (5609007) 100.00% compared to head (9b389a0) 100.00%.

❗ Current head 9b389a0 differs from pull request most recent head 78b9c0f. Consider uploading reports for the commit 78b9c0f to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##              master       #89   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity        85        91    +6     
===========================================
  Files              7         7           
  Lines            230       239    +9     
===========================================
+ Hits             230       239    +9     
Files Changed Coverage Δ
src/MiddlewareFactory.php 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@what-the-diff
Copy link

what-the-diff bot commented Sep 16, 2023

PR Summary

  • Extend Capability of MiddlewareFactory Class
    The update enables the MiddlewareFactory to handle and support PSR-15 request handler classes and also invokable classes.

  • Addition of InvokeableAction and SimpleRequestHandler classes
    Two new classes, InvokeableAction and SimpleRequestHandler, have been implemented to facilitate handling of invokable middleware and request handlers.

  • Enhancement of Test Coverage
    To ensure everything is working as expected, extra testing cases have been integrated into the MiddlewareDispatcherTest and MiddlewareFactoryTest classes.

  • Support for Simple Request Handler Implementation
    The introduction of SimpleRequestHandler allows straightforward execution and handling of requests.

src/MiddlewareFactory.php Show resolved Hide resolved
src/MiddlewareFactory.php Outdated Show resolved Hide resolved
src/MiddlewareFactory.php Show resolved Hide resolved
@rustamwin rustamwin requested a review from vjik September 18, 2023 14:20
@vjik vjik merged commit ab81158 into master Sep 19, 2023
14 checks passed
@vjik vjik deleted the fix-85 branch September 19, 2023 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants