Add rector [batch]

.github/workflows/rector.yml

@@ -0,0 +1,21 @@
+on:
+  pull_request:
+    paths-ignore:
+      - 'docs/**'
+      - 'README.md'
+      - 'CHANGELOG.md'
+      - '.gitignore'
+      - '.gitattributes'
+      - 'infection.json.dist'
+      - 'psalm.xml'
+
+name: rector
+
+jobs:
+  rector:
+    uses: yiisoft/actions/.github/workflows/rector.yml@master
+    with:
+      os: >-
+        ['ubuntu-latest']
+      php: >-
+        ['8.0']

composer.json

@@ -23,6 +23,7 @@
     },
     "require-dev": {
         "phpunit/phpunit": "^9.5",
+        "rector/rector": "^0.14.3",
         "roave/infection-static-analysis-plugin": "^1.16",
         "spatie/phpunit-watcher": "^1.23",
         "vimeo/psalm": "^4.18"

rector.php

@@ -0,0 +1,22 @@
+<?php
+
+declare(strict_types=1);
+
+use Rector\CodeQuality\Rector\Class_\InlineConstructorDefaultToPropertyRector;
+use Rector\Config\RectorConfig;
+use Rector\Set\ValueObject\LevelSetList;
+
+return static function (RectorConfig $rectorConfig): void {
+    $rectorConfig->paths([
+        __DIR__ . '/src',
+        __DIR__ . '/tests',
+    ]);
+
+    // register a single rule
+    $rectorConfig->rule(InlineConstructorDefaultToPropertyRector::class);
+
+    // define sets of rules
+    $rectorConfig->sets([
+        LevelSetList::UP_TO_PHP_80,
+    ]);
+};

src/DnsHelper.php

@@ -32,7 +32,7 @@ public static function existsMx(string $hostname): bool
 
         restore_error_handler();
 
-        return count($result) > 0;
+        return (is_countable($result) ? count($result) : 0) > 0;
     }
 
     /**
@@ -55,7 +55,7 @@ public static function existsA(string $hostname): bool
 
         restore_error_handler();
 
-        return count($result) > 0;
+        return (is_countable($result) ? count($result) : 0) > 0;
     }
 
     /**
@@ -69,7 +69,7 @@ public static function existsA(string $hostname): bool
      */
     public static function acceptsEmails(string $hostnameOrEmail): bool
     {
-        if (strpos($hostnameOrEmail, '@') !== false) {
+        if (str_contains($hostnameOrEmail, '@')) {
             [, $hostnameOrEmail] = explode('@', $hostnameOrEmail, 2);
         }
         return self::existsMx($hostnameOrEmail) || self::existsA($hostnameOrEmail);

src/IpHelper.php

@@ -60,7 +60,7 @@ public static function getIpVersion(string $ip, bool $validate = true): int
         if ($ipStringLength < 2) {
             throw new InvalidArgumentException("Unrecognized address $ip", 10);
         }
-        $preIpVersion = strpos($ip, ':') === false ? self::IPV4 : self::IPV6;
+        $preIpVersion = !str_contains($ip, ':') ? self::IPV4 : self::IPV6;
         if ($preIpVersion === self::IPV4 && $ipStringLength < 7) {
             throw new InvalidArgumentException("Unrecognized address $ip", 11);
         }
@@ -123,7 +123,7 @@ public static function inRange(string $subnet, string $range): bool
         $binNet = self::ip2bin($net);
         $masked = substr($binNet, 0, (int) $netMask);
 
-        return ($masked === '' || strpos($binIp, $masked) === 0) && $mask >= $netMask;
+        return ($masked === '' || str_starts_with($binIp, $masked)) && $mask >= $netMask;
     }
 
     /**