Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow empty trusted IPs #31

Merged
merged 6 commits into from
Jun 29, 2023
Merged

Conversation

arogachev
Copy link
Contributor

Q A
Is bugfix? ✔️/❌
New feature? ✔️/❌
Breaks BC?

@arogachev arogachev changed the base branch from master to parse-port-from-host June 27, 2023 08:37
@arogachev arogachev requested a review from a team June 27, 2023 08:37
@arogachev arogachev self-assigned this Jun 27, 2023
@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.24 🎉

Comparison is base (0578a36) 98.70% compared to head (ae3af82) 98.95%.

Additional details and impacted files
@@                    Coverage Diff                     @@
##             parse-port-from-host      #31      +/-   ##
==========================================================
+ Coverage                   98.70%   98.95%   +0.24%     
- Complexity                    136      137       +1     
==========================================================
  Files                           2        2              
  Lines                         385      381       -4     
==========================================================
- Hits                          380      377       -3     
+ Misses                          5        4       -1     
Impacted Files Coverage Δ
src/TrustedHostsNetworkResolver.php 98.75% <100.00%> (+0.29%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

README.md Outdated Show resolved Hide resolved
@samdark samdark merged commit 9ebbfbf into parse-port-from-host Jun 29, 2023
19 of 21 checks passed
@samdark samdark deleted the allow-empty-trusted-ips branch June 29, 2023 15:34
@samdark
Copy link
Member

samdark commented Jun 29, 2023

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants