Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TrustedHostsNetworkResolver - Disallow IPs from private network #32

Merged
merged 23 commits into from
Jun 30, 2023
Merged

TrustedHostsNetworkResolver - Disallow IPs from private network #32

merged 23 commits into from
Jun 30, 2023

Conversation

arogachev
Copy link
Contributor

Q A
Is bugfix? ✔️
New feature? ❌
Breaks BC? ❌

@arogachev arogachev requested a review from a team June 28, 2023 08:40
@arogachev arogachev self-assigned this Jun 28, 2023
@arogachev arogachev added type:task Task type:bug Bug and removed type:task Task labels Jun 28, 2023
@arogachev arogachev linked an issue Jun 28, 2023 that may be closed by this pull request
TrustedHostsNetworkResolver - private network IPs should not be a valid result #19
Closed
@codecov
Copy link

codecov bot commented Jun 28, 2023 •
edited

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01 🎉

Comparison is base (081c2fa) 98.95% compared to head (c54dd78) 98.96%.

Additional details and impacted files 
@@             Coverage Diff              @@
##             master      #32      +/-   ##
============================================
+ Coverage     98.95%   98.96%   +0.01%     
- Complexity      137      140       +3     
============================================
  Files             2        2              
  Lines           381      385       +4     
============================================
+ Hits            377      381       +4     
  Misses            4        4
Impacted Files Coverage Δ
src/TrustedHostsNetworkResolver.php 98.76% <100.00%> (+0.01%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

samdark
samdark approved these changes Jun 29, 2023
View reviewed changes
src/TrustedHostsNetworkResolver.php Outdated Show resolved Hide resolved
src/TrustedHostsNetworkResolver.php Outdated Show resolved Hide resolved
Base automatically changed from allow-empty-trusted-ips to parse-port-from-host June 29, 2023 15:34
Base automatically changed from parse-port-from-host to master June 29, 2023 15:37
@arogachev arogachev merged commit 2d5c658 into master Jun 30, 2023
11 of 12 checks passed
@arogachev arogachev deleted the disallow-private-ips branch June 30, 2023 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samdark samdark samdark approved these changes

Assignees

@arogachev arogachev

Labels
type:bug Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TrustedHostsNetworkResolver - private network IPs should not be a valid result
2 participants
@arogachev @samdark