Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add envelope stack + MessageSerializer #188

Merged
merged 15 commits into from
Jan 22, 2024
Merged

Add envelope stack + MessageSerializer #188

merged 15 commits into from
Jan 22, 2024

Conversation

xepozz
Copy link
Contributor

@xepozz xepozz commented Jan 13, 2024

No description provided.

@xepozz xepozz requested a review from a team January 13, 2024 17:10
@xepozz xepozz added the status:code review The pull request needs review. label Jan 13, 2024
@xepozz xepozz changed the title Add envelope stack Add envelope stack + MessageSerializer Jan 13, 2024
Copy link

codecov bot commented Jan 21, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (5339df8) 83.98% compared to head (bf62af9) 84.65%.

Files Patch % Lines
src/Message/EnvelopeTrait.php 85.71% 2 Missing ⚠️
config/di.php 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #188      +/-   ##
============================================
+ Coverage     83.98%   84.65%   +0.66%     
- Complexity      359      372      +13     
============================================
  Files            46       47       +1     
  Lines          1049     1088      +39     
============================================
+ Hits            881      921      +40     
+ Misses          168      167       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@samdark
Copy link
Member

samdark commented Jan 22, 2024

@xepozz would be awesome to have a section about it in docs.

@samdark samdark merged commit fb5d3c6 into master Jan 22, 2024
16 checks passed
@samdark samdark deleted the envelope-stack branch January 22, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants