Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Envelope trait fixed to be compatible with EnvelopeInterface. #205

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

holdmann
Copy link

Q A
Is bugfix? ✔️
New feature?
Breaks BC?

[2024-05-26 18:37:09] main.ALERT: Fatal Error (E_COMPILE_ERROR): Declaration of Yiisoft\Queue\Message\IdEnvelope::fromMessage(Yiisoft\Queue\Message\MessageInterface $message): Yiisoft\Queue\Message\IdEnvelope must be compatible with Yiisoft\Queue\Message\EnvelopeInterface::fromMessage(Yiisoft\Queue\Message\MessageInterface $message): Yiisoft\Queue\Message\EnvelopeInterface

Copy link

codecov bot commented May 26, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 84.30%. Comparing base (b47a41f) to head (622d9d1).
Report is 3 commits behind head on master.

Files Patch % Lines
src/Message/EnvelopeTrait.php 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #205      +/-   ##
============================================
- Coverage     84.65%   84.30%   -0.36%     
  Complexity      372      372              
============================================
  Files            47       47              
  Lines          1088     1051      -37     
============================================
- Hits            921      886      -35     
+ Misses          167      165       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant