Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Psalm 1 + Update StyleCI configuration #34

Merged
merged 5 commits into from
Mar 2, 2023
Merged

Psalm 1 + Update StyleCI configuration #34

merged 5 commits into from
Mar 2, 2023

Conversation

vjik
Copy link
Member

@vjik vjik commented Feb 25, 2023

Q A
Is bugfix?
New feature?
Breaks BC?
Fixed issues -

@codecov
Copy link

codecov bot commented Feb 25, 2023

Codecov Report

Base: 90.80% // Head: 92.35% // Increases project coverage by +1.55% 🎉

Coverage data is based on head (aaa882d) compared to base (875056b).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master      #34      +/-   ##
============================================
+ Coverage     90.80%   92.35%   +1.55%     
  Complexity       60       60              
============================================
  Files             4        4              
  Lines           250      301      +51     
============================================
+ Hits            227      278      +51     
  Misses           23       23              
Impacted Files Coverage Δ
src/AssignmentsStorage.php 98.71% <100.00%> (+0.33%) ⬆️
src/ItemsStorage.php 97.12% <100.00%> (+0.96%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vjik vjik requested a review from a team February 25, 2023 07:54
@vjik vjik added the status:code review The pull request needs review. label Feb 25, 2023
@vjik vjik changed the title Psalm 1 Psalm 1 + Update StyleCI configuration Feb 25, 2023
Copy link
Contributor

@arogachev arogachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine except some annotations are not Psalm specific.

src/AssignmentsStorage.php Show resolved Hide resolved
src/AssignmentsStorage.php Show resolved Hide resolved
src/AssignmentsStorage.php Show resolved Hide resolved
src/ItemsStorage.php Show resolved Hide resolved
src/ItemsStorage.php Show resolved Hide resolved
src/ItemsStorage.php Show resolved Hide resolved
src/ItemsStorage.php Show resolved Hide resolved
src/ItemsStorage.php Show resolved Hide resolved
src/ItemsStorage.php Show resolved Hide resolved
@arogachev arogachev merged commit b795aa1 into master Mar 2, 2023
@arogachev arogachev deleted the psalm-1 branch March 2, 2023 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants