Micro optimization related with cloning object

yiisoft · Sep 28, 2023 · 132c402 · 132c402
1 parent 11b289b
commit 132c402
Showing 1 changed file with 11 additions and 3 deletions.
diff --git a/src/ItemsStorage.php b/src/ItemsStorage.php
@@ -431,12 +431,20 @@ private function createItem(
         string|null $description = null,
         string|null $ruleName = null,
     ): Permission|Role {
-        return $this
+        $item = $this
             ->createItemByTypeAndName($type, $name)
-            ->withDescription($description ?? '')
-            ->withRuleName($ruleName ?? null)
             ->withCreatedAt((int) $createdAt)
             ->withUpdatedAt((int) $updatedAt);
+
+        if ($description !== null) {
+            $item = $item->withDescription($description);
+        }
+
+        if ($ruleName !== null) {
+            $item = $item->withRuleName($ruleName);
+        }
+
+        return $item;
     }
 
     /**