Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync with base package #57

Merged
merged 14 commits into from Jan 16, 2024
Merged

Sync with base package #57

merged 14 commits into from Jan 16, 2024

Conversation

arogachev
Copy link
Contributor

Q A
Is bugfix? ✔️
New feature? ✔️
Breaks BC? ✔️

@arogachev arogachev marked this pull request as draft January 12, 2024 15:01
Copy link

codecov bot commented Jan 15, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (2814c54) 96.20% compared to head (a98b417) 99.21%.
Report is 3 commits behind head on master.

Files Patch % Lines
src/ItemsStorage.php 91.89% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master      #57      +/-   ##
============================================
+ Coverage     96.20%   99.21%   +3.01%     
- Complexity      151      192      +41     
============================================
  Files             7       11       +4     
  Lines           659      766     +107     
============================================
+ Hits            634      760     +126     
+ Misses           25        6      -19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arogachev arogachev self-assigned this Jan 16, 2024
@arogachev arogachev added this to the 2.0 milestone Jan 16, 2024
@arogachev arogachev marked this pull request as ready for review January 16, 2024 14:38
@arogachev arogachev merged commit a630c52 into master Jan 16, 2024
42 of 43 checks passed
@arogachev arogachev deleted the base-sync branch January 16, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants