Fix changelog, psalm type and add not null check (#196)

yiisoft · Sep 27, 2023 · aa7acbe · aa7acbe
1 parent 5c24a71
commit aa7acbe
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -9,9 +9,9 @@
 - Enh #134: Improve handling and control of `Assignment::$createdAt` (@arogachev)
 - Chg #134: Add `$createdAt` parameter to `ManagerInterface::assign()` (@arogachev)
 - Chg #134: Replace parameters with `$assignment` parameter in `AssignmentsStorageInterface::add()` (@arogachev)
-- Enh #165: Improve perfomance (@arogachev)
-- Enh #165: Rename `getChildren` method to `getDirectAchildren()` in `ItemsStorage` (@arogachev)
-- Enh #165: Add methods to `ItemsStorage`:
+- Enh #165: Improve performance (@arogachev)
+- Enh #165: Rename `getChildren` method to `getDirectAchildren()` in `ItemsStorageInterface` (@arogachev)
+- Enh #165: Add methods to `ItemsStorageInterface`:
     - `roleExists()`;
     - `getRolesByNames()`;
     - `getPermissionsByNames()`;

diff --git a/src/ItemsStorageInterface.php b/src/ItemsStorageInterface.php
@@ -7,7 +7,7 @@
 /**
  * A storage for RBAC roles and permissions used in {@see Manager}.
  *
- * @psalm-type ItemsIndexedByName = array<string, Permission|Role>
+ * @psalm-type ItemsIndexedByName = array<string, Item>
  */
 interface ItemsStorageInterface
 {

diff --git a/tests/Common/AssignmentsStorageTestTrait.php b/tests/Common/AssignmentsStorageTestTrait.php
@@ -160,6 +160,7 @@ public function testGet(): void
         $storage = $this->getAssignmentsStorage();
         $assignment = $storage->get('Manager', 'jack');
 
+        $this->assertNotNull($assignment);
         $this->assertSame('Manager', $assignment->getItemName());
         $this->assertSame('jack', $assignment->getUserId());
         $this->assertIsInt($assignment->getCreatedAt());