Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix psalm #140

Merged
merged 1 commit into from
Feb 12, 2024
Merged

Fix psalm #140

merged 1 commit into from
Feb 12, 2024

Conversation

vjik
Copy link
Member

@vjik vjik commented Feb 12, 2024

Q A
Is bugfix?
New feature?
Breaks BC?

Copy link

what-the-diff bot commented Feb 12, 2024

PR Summary

  • New Job Configuration Added for Psalm80
    A new job by the name psalm80 has been added which uses a different set of rules for 'Psalm'. 'Psalm' is a tool to identify errors in PHP code. This job is specifically created for PHP version 8.0. The configurations for this job are specified in the new psalm80.xml file.

  • Updated Psalm Package Version
    The version of the Psalm tool that we use has been updated in our composer.json file. The package versions have been updated to ^4.30|^5.21 from ^4.30|^5.6. This means we are now using a newer and improved version of the Psalm tool.

  • New Issue Handlers in Psalm Configuration
    We have added new issue handlers in our 'Psalm' tool configuration. These are MixedAssignment and RiskyTruthyFalsyComparison. Adding these will help us identify a wider range of potential errors in our code.

  • Created Psalm80.xml file
    A new psalm80.xml file has been created. This file includes a specific configuration for PHP version 8.0. It specifically includes suppressing the MixedAssignment issue which can be more lenient in running checks for the PHP 8.0 version. It is important to note that suppression of certain issues is sometimes required to ensure that only important potential problems are flagged.

@vjik vjik merged commit 6b208e6 into master Feb 12, 2024
21 of 22 checks passed
@vjik vjik deleted the psalm branch February 12, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant