Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move type hints from annotations to methods signature + Cleanup + MSI 100% #178

Merged
merged 12 commits into from Nov 12, 2022

Conversation

vjik
Copy link
Member

@vjik vjik commented Nov 11, 2022

Q A
Is bugfix?
New feature?
Breaks BC? ✔️
Fixed issues -

@what-the-diff
Copy link

what-the-diff bot commented Nov 11, 2022

  • Update .editorconfig file
  • Add new changes to CHANGELOG.md
  • Remove dependency-checker from composer and update README with instructions on how to install the package without --prefer-dist flag
  • Change type hints in CurrentRoute, Group, MatchingResult classes from annotations to methods signature (PHP 8)
  • Fix some typos in docblocks of RouteCollectorInterface class: add missing return types for middleware() and prependMiddleware() methods; fix wrong param name $middlewaresDefinition -> $middlewareDefinitions; remove @return self annotation as it is redundant since all these functions are returning this object anyway
  • Added support for named arguments in middleware methods.
  • Fixed duplicate hosts issue (now they are removed).
  • Updated RouteNotFoundException message format according PSR-7 standards: https://www.php-fig.org/psr/psr-7/#32-message . Also added unit tests for exception constructor parameters validation logic since there were no such tests before but I found a bug while working on this PR :)
    5`. Improved debug info output formatting + minor fixes here & there...

@codecov
Copy link

codecov bot commented Nov 11, 2022

Codecov Report

Base: 97.61% // Head: 97.61% // No change to project coverage 👍

Coverage data is based on head (05f9759) compared to base (ebffb51).
Patch coverage: 92.85% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #178   +/-   ##
=========================================
  Coverage     97.61%   97.61%           
+ Complexity      144      140    -4     
=========================================
  Files            10       10           
  Lines           378      378           
=========================================
  Hits            369      369           
  Misses            9        9           
Impacted Files Coverage Δ
src/MatchingResult.php 100.00% <ø> (ø)
src/UrlGeneratorInterface.php 0.00% <0.00%> (ø)
src/CurrentRoute.php 100.00% <100.00%> (ø)
src/Group.php 100.00% <100.00%> (ø)
src/Route.php 100.00% <100.00%> (ø)
src/RouteCollector.php 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

# Conflicts:
#	src/UrlGeneratorInterface.php
@vjik vjik requested a review from a team November 11, 2022 15:11
@vjik vjik added the status:code review The pull request needs review. label Nov 11, 2022
@rustamwin rustamwin merged commit f813e56 into master Nov 12, 2022
@rustamwin rustamwin deleted the enh branch November 12, 2022 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants